Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: NoneType err on creation #59

Merged
merged 2 commits into from
Nov 22, 2024
Merged

Conversation

dannyl1u
Copy link
Owner

fix bug where it was comparing to non existent issues

Copy link

After reviewing the pull request code diff and description, here are some potential issues or downsides that I've identified:

  1. Missing import: The add_issues_to_chroma function now requires a repo_id parameter, but there's no indication of how this parameter will be handled in other parts of the codebase.
  2. No handling for NoneType error on creation: Although the title suggests fixing a bug related to NoneType errors, I couldn't find any changes that address this issue specifically. It's possible that the fix is more subtle and not directly visible in the code diff.
  3. Changes in comment text: The new pull request has different comment texts for similar issues with high or low similarity thresholds. This might break existing logic or functionality if other parts of the system rely on these specific comments.
  4. New behavior when no similar issues are found: The updated handle_new_issue function now leaves a comment indicating that "No similar issues were found." However, it's unclear whether this change is intended to be backwards compatible with previous behavior.

To consider these points, I'd like to ask the PR author:

Have you considered how these changes might affect existing functionality or logic in the codebase? Are there any potential side effects or interactions that need to be addressed before merging this pull request?

@dannyl1u dannyl1u merged commit 9fff546 into main Nov 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant